westonpace commented on code in PR #35505:
URL: https://github.com/apache/arrow/pull/35505#discussion_r1188898933
##########
python/pyarrow/tests/test_exec_plan.py:
##########
@@ -115,12 +120,19 @@ def test_joins(jointype, expected, use_threads,
use_datasets):
t2 = ds.dataset([t2])
r = _perform_join(jointype, t1, "colA", t2, "colB",
- use_threads=use_threads, coalesce_keys=True)
+ use_threads=use_threads, coalesce_keys=coalesce_keys)
r = r.combine_chunks()
if "right" in jointype:
r = r.sort_by("colB")
else:
r = r.sort_by("colA")
+ if coalesce_keys:
+ if jointype in ("inner", "left outer"):
+ expected = expected.drop(["colB"])
+ elif jointype == "right outer":
+ expected = expected.drop(["colA"])
+ elif jointype == "full outer":
+ expected = expected.drop(["colB"]).set_column(0, "colA", [[1, 2,
6, 99]])
Review Comment:
Does this work? I wouldn't expect this behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
