mr-brobot commented on PR #4188: URL: https://github.com/apache/arrow-rs/pull/4188#issuecomment-1540923134
@tustvold I like that suggestion. Implemented as `aws::resolve_bucket_region`. ✅ I'd like your feedback on the tests too... They hit the S3 HeadBucket API using some bucket names that work today, but that might not be true forever (someone could create a bucket named "please-dont-exist"). This was to show it working in PR, but maybe better to convert to unit tests by creating a private `head_bucket` function with different implementations for test/live? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
