jackwener commented on code in PR #4185:
URL: https://github.com/apache/arrow-rs/pull/4185#discussion_r1189412019
##########
arrow-cast/src/cast.rs:
##########
@@ -149,114 +153,54 @@ pub fn can_cast_types(from_type: &DataType, to_type:
&DataType) -> bool {
(Null | Int8 | Int16 | Int32 | Int64 | Float32 | Float64,
Decimal128(_, _)) |
(Null | Int8 | Int16 | Int32 | Int64 | Float32 | Float64,
Decimal256(_, _)) |
// decimal to unsigned numeric
- (Decimal128(_, _), UInt8 | UInt16 | UInt32 | UInt64) |
- (Decimal256(_, _), UInt8 | UInt16 | UInt32 | UInt64) |
+ (Decimal128(_, _) | Decimal256(_, _), UInt8 | UInt16 | UInt32 |
UInt64) |
// decimal to signed numeric
- (Decimal128(_, _), Null | Int8 | Int16 | Int32 | Int64 | Float32 |
Float64) |
- (Decimal256(_, _), Null | Int8 | Int16 | Int32 | Int64 | Float32 |
Float64) => true,
+ (Decimal128(_, _) | Decimal256(_, _), Null | Int8 | Int16 | Int32 |
Int64 | Float32 | Float64) => true,
// decimal to Utf8
- (Decimal128(_, _), Utf8 | LargeUtf8) => true,
- (Decimal256(_, _), Utf8 | LargeUtf8) => true,
+ (Decimal128(_, _) | Decimal256(_, _), Utf8 | LargeUtf8) => true,
// Utf8 to decimal
- (Utf8 | LargeUtf8, Decimal128(_, _)) => true,
- (Utf8 | LargeUtf8, Decimal256(_, _)) => true,
- (Decimal128(_, _), _) => false,
- (_, Decimal128(_, _)) => false,
- (Decimal256(_, _), _) => false,
- (_, Decimal256(_, _)) => false,
Review Comment:
> Hm, is this same as before?
@viirya Yes, I just merge them together
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
