pitrou commented on PR #35340: URL: https://github.com/apache/arrow/pull/35340#issuecomment-1541510523
> @pitrou it's hypothetical but possible as I explained in [#35340 (comment)](https://github.com/apache/arrow/pull/35340#issuecomment-1523520894) I don't agree with this comment. The destructor is defined as `virtual` in the base class. You don't need to redefine it in the derived class. > And @mapleFU has brought up the point about the LTO build needing this somehow. Note that all classes in the file have done this and the class I added wasn't following the pattern. Fair enough. But can you change the PR description to match this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
