alamb commented on issue #6261: URL: https://github.com/apache/arrow-datafusion/issues/6261#issuecomment-1541933154
Makes sense @liukun4515 -- I agree it sounds like a good step forward to store the type of exprs. > Once the common type and result are calculated in the logical phase, any changes for the type of expr should be forbidden. Yes, this makes a lot of sense to me @viirya I think ran into some possibly related problem when working on decimal multiplication that required recasting in physical expressions. Would we be able to avoid such a case like: https://github.com/apache/arrow-datafusion/blob/8a25953182b361a58c56384129bf57f32aa2dbb1/datafusion/physical-expr/src/expressions/binary.rs#L674-L688 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
