pitrou commented on code in PR #35522:
URL: https://github.com/apache/arrow/pull/35522#discussion_r1189816831
##########
cpp/src/arrow/scalar.cc:
##########
@@ -153,9 +153,10 @@ struct ScalarHashImpl {
Status ArrayHash(const ArrayData& a) {
RETURN_NOT_OK(StdHash(a.length) & StdHash(a.GetNullCount()));
- if (a.buffers[0] != nullptr) {
+ if (a.GetNullCount() != 0) {
Review Comment:
Indeed, however, a NullArray can have a non-zero null count but without a
null bitmap. So you must make sure to check the buffers as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
