pitrou commented on code in PR #35499: URL: https://github.com/apache/arrow/pull/35499#discussion_r1190063977
########## cpp/src/arrow/adapters/orc/util.cc: ########## @@ -951,6 +952,15 @@ Status WriteBatch(const Array& array, int64_t orc_offset, } } +void SetAttributes(const std::shared_ptr<arrow::Field>& field, liborc::Type* type) { + if (field->HasMetadata()) { + const auto& metadata = field->metadata(); + for (int j = 0; j < metadata->size(); j++) { Review Comment: ```suggestion for (int64_t j = 0; j < metadata->size(); j++) { ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org