WillAyd commented on code in PR #610:
URL: https://github.com/apache/arrow-adbc/pull/610#discussion_r1190080895
##########
dev/release/verify-release-candidate.sh:
##########
@@ -434,7 +434,8 @@ test_cpp() {
export BUILD_DRIVER_POSTGRESQL=0
# Snowflake driver requires snowflake creds for testing
export BUILD_DRIVER_SNOWFLAKE=0
- "${ADBC_DIR}/ci/scripts/cpp_test.sh" "${ADBC_SOURCE_DIR}"
"${ARROW_TMPDIR}/cpp-build" "${install_prefix}"
+ "${ADBC_DIR}/ci/scripts/cpp_build.sh" "${ADBC_SOURCE_DIR}"
"${ARROW_TMPDIR}/cpp-build" "${install_prefix}"
+ "${ADBC_DIR}/ci/scripts/cpp_test.sh" "${ARROW_TMPDIR}/cpp-build"
"${install_prefix}"
Review Comment:
This is a holdover from the previous design pattern where the environment
variables were passed to just the build step, so you would build then `ctest`
anything that was built. Should be removed since we are using the labels
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
