felipecrv commented on PR #35533: URL: https://github.com/apache/arrow/pull/35533#issuecomment-1542428367
> `ARROW_EXPORT` should only be useful in declarations, so I'm not sure why you're adding it in `data.cc`. I already had them in the header and got the wrong impression from the windows compiler errors. @mapleFU's fix really is the way to go -- with the `ARROW_FRIEND_EXPORT` -- that's the real missing export declaration. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
