alamb opened a new pull request, #6329: URL: https://github.com/apache/arrow-datafusion/pull/6329
# Which issue does this PR close? Closes https://github.com/apache/arrow-datafusion/issues/6328 (noticed by @mustafasrepo on https://github.com/apache/arrow-datafusion/pull/6234) # Rationale for this change For some reason, `cargo test --test sqllogictests -- --complete` when completing tests strips the leading whitespace sometimes. Then the comparison also ignores leading whitespace So sometimes the explain plans captured by `--compete` would take a plan like: ``` Projection Sort Window Sort ``` And display it like: ``` Projection Sort Window Sort ``` # What changes are included in this PR? 1. Update the normalization code in the DataFusion `sqlogictest` to prefix explain plan lines with `|` 2. Recapture the explain plans`cargo test --test sqllogictests -- --complete` # Are these changes tested? Yes <!-- We typically require tests for all PRs in order to: 1. Prevent the code from being accidentally broken by subsequent changes 3. Serve as another way to document the expected behavior of the code If tests are not included in your PR, please explain why (for example, are they covered by existing tests)? --> # Are there any user-facing changes? no <!-- If there are user-facing changes then we may require documentation to be updated before approving the PR. --> <!-- If there are any breaking changes to public APIs, please add the `api change` label. --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
