danepitkin commented on PR #35395: URL: https://github.com/apache/arrow/pull/35395#issuecomment-1542530837
> LGTM +1 > > Just a small nit though: I would also add a test for casting `float` to `int`, using default safe option and an unsafe casting option. Not sure about the memory pool though. > > Yes, the failing tests are not related, I have created an issue for it: #35490 Great idea! I will add this test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
