roeap commented on code in PR #4192:
URL: https://github.com/apache/arrow-rs/pull/4192#discussion_r1190195509
##########
object_store/src/client/mod.rs:
##########
@@ -43,6 +45,14 @@ fn map_client_error(e: reqwest::Error) -> super::Error {
static DEFAULT_USER_AGENT: &str =
concat!(env!("CARGO_PKG_NAME"), "/", env!("CARGO_PKG_VERSION"),);
+/// Configuration keys for [`ClientOptions`]
+#[derive(PartialEq, Eq, Hash, Clone, Debug, Copy, Deserialize, Serialize)]
+#[non_exhaustive]
+pub enum ClientConfigKey {
+ /// Allow non-TLS, i.e. non-HTTPS connections
+ AllowHttp,
+}
+
Review Comment:
Some users in delta-rs are asking to expose more client options on the
python side, for this having some more keys defined might be helpful. Do you
think this is something object_store wants to do in a follow-up?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
