westonpace commented on code in PR #35055:
URL: https://github.com/apache/arrow/pull/35055#discussion_r1190244016
##########
r/R/dataset-format.R:
##########
@@ -113,6 +115,35 @@ ParquetFileFormat$create <- function(...,
#' @export
IpcFileFormat <- R6Class("IpcFileFormat", inherit = FileFormat)
+#' JSON dataset file format
+#'
+#' @description
+#' A `JsonFileFormat` is a [FileFormat] subclass which holds information about
how to
+#' read and parse the files included in a JSON `Dataset`.
+#'
+#' @section Factory:
+#' `JsonFileFormat$create()` can take options in the form of lists passed
through as `parse_options`,
+#' or `read_options` parameters.
Review Comment:
Is it clear to the user what they should pass in for `parse_options` and
`read_options`?
Also, some of the parse options don't apply when used in a datasets context
(as opposed to reading a single file). I believe we ignore `explicit_schema`
(in favor of the dataset schema) and `unexpected_field_behavior` (we default to
ignore I think since we need to tolerate partial reads).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
