zeroshade commented on code in PR #677:
URL: https://github.com/apache/arrow-adbc/pull/677#discussion_r1190392134
##########
c/validation/adbc_validation.cc:
##########
@@ -1248,11 +1258,10 @@ void StatementTest::TestSqlIngestSample() {
IsOkStatus(&error));
ASSERT_THAT(AdbcStatementNew(&connection, &statement, &error),
IsOkStatus(&error));
- ASSERT_THAT(
- AdbcStatementSetSqlQuery(
- &statement, "SELECT * FROM bulk_ingest ORDER BY \"int64s\" ASC NULLS
FIRST",
- &error),
- IsOkStatus(&error));
+ ASSERT_THAT(AdbcStatementSetSqlQuery(
+ &statement, "SELECT * FROM bulk_ingest ORDER BY int64s ASC
NULLS FIRST",
Review Comment:
well in this case it's not the table name, it's the column name that's the
issue. Because snowflake unconditionally upper-cases things which aren't
quoted, when you add double quotes, it keeps it lower cased and then it can't
find the column because `int64s` != `INT64S`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
