viirya commented on code in PR #6331:
URL: https://github.com/apache/arrow-datafusion/pull/6331#discussion_r1190785220
##########
datafusion/expr/src/type_coercion/binary.rs:
##########
@@ -514,7 +514,7 @@ pub fn coercion_decimal_mathematics_type(
left_decimal_type,
right_decimal_type,
),
- Operator::Multiply | Operator::Divide | Operator::Modulo => {
+ Operator::Divide | Operator::Modulo => {
get_wider_decimal_type(left_decimal_type, right_decimal_type)
}
Review Comment:
Hm, I remember this follows Spark decimal coercion rule to cast lhs/rhs to
wider decimal type. I don't see Spark does this now for multiply.
Yea, you should be correct. We don't need to cast lhs/rhs to wider decimal
type for multiply.
It's too late. Let me think it again tomorrow morning. 😄
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
