alamb commented on a change in pull request #8866:
URL: https://github.com/apache/arrow/pull/8866#discussion_r539236791
##########
File path: rust/datafusion/src/datasource/datasource.rs
##########
@@ -24,6 +24,15 @@ use crate::arrow::datatypes::SchemaRef;
use crate::error::Result;
use crate::physical_plan::ExecutionPlan;
+/// The table statistics
+#[derive(Clone)]
+pub struct Statistics {
+ /// The number of table rows
+ pub num_rows: i64,
Review comment:
I think `usize` is good enough to begin with -- if we need to change it
ot u64 for some reason in the future (e.g. to support > 4GB files on 32-bit
architectures) that should be a straightforward change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
