tustvold commented on code in PR #4203:
URL: https://github.com/apache/arrow-rs/pull/4203#discussion_r1191256848
##########
object_store/src/prefix.rs:
##########
@@ -59,36 +56,63 @@ impl<T: ObjectStore> PrefixStore<T> {
}
/// Strip the constant prefix from a given path
- fn strip_prefix(&self, path: &Path) -> Option<Path> {
- Some(path.prefix_match(&self.prefix)?.collect())
+ fn strip_prefix(&self, path: Path) -> Path {
Review Comment:
It is a bug if we ever receive values outside the prefix from the inner
store, some logic was just not stripping and some was ignoring, we now handle
this consistently
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
