tustvold commented on code in PR #4208:
URL: https://github.com/apache/arrow-rs/pull/4208#discussion_r1192244173
##########
object_store/src/client/mod.rs:
##########
@@ -115,14 +212,45 @@ impl ClientOptions {
pub fn get_config_value(&self, key: &ClientConfigKey) -> Option<String> {
match key {
ClientConfigKey::AllowHttp => Some(self.allow_http.to_string()),
+ ClientConfigKey::AllowInvalidCertificates => {
+ Some(self.allow_insecure.to_string())
+ }
+ ClientConfigKey::ConnectTimeout => {
+ self.connect_timeout.as_ref().map(fmt_duration)
+ }
+ ClientConfigKey::DefaultContentType =>
self.default_content_type.clone(),
+ ClientConfigKey::Http1Only => Some(self.http1_only.to_string()),
+ ClientConfigKey::Http2KeepAliveInterval => {
+ self.http2_keep_alive_interval.as_ref().map(fmt_duration)
+ }
+ ClientConfigKey::Http2KeepAliveTimeout => {
+ self.http2_keep_alive_timeout.as_ref().map(fmt_duration)
+ }
+ ClientConfigKey::Http2KeepAliveWhileIdle => {
+ Some(self.http2_keep_alive_while_idle.to_string())
+ }
+ ClientConfigKey::Http2Only => Some(self.http2_only.to_string()),
+ ClientConfigKey::PoolIdleTimeout => {
+ self.pool_idle_timeout.as_ref().map(fmt_duration)
+ }
+ ClientConfigKey::PoolMaxIdlePerHost => {
+ self.pool_max_idle_per_host.as_ref().map(|v| v.to_string())
+ }
+ ClientConfigKey::ProxyUrl => self.proxy_url.clone(),
+ ClientConfigKey::Timeout =>
self.timeout.as_ref().map(fmt_duration),
+ ClientConfigKey::UserAgent => self
Review Comment:
You might be able to make this more legible by using `?`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
