bkietz commented on a change in pull request #8877:
URL: https://github.com/apache/arrow/pull/8877#discussion_r539410870
##########
File path: cpp/src/arrow/compute/kernels/vector_sort.cc
##########
@@ -137,6 +138,30 @@ struct ChunkedArrayResolver {
mutable int64_t cached_chunk_;
};
+// We could try to reproduce the concrete Array classes' facilities
+// (such as cached raw values pointer) in a separate hierarchy of
+// physical accessors, but doing so ends up too cumbersome.
+// Instead, we simply create the desired concrete Array objects.
+ArrayVector GetPhysicalChunks(const ChunkedArray& chunked_array,
Review comment:
Doesn't this duplicate `ChunkedArray::View`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
