thisisnic commented on code in PR #35473:
URL: https://github.com/apache/arrow/pull/35473#discussion_r1192930273
##########
r/tests/testthat/test-dplyr-mutate.R:
##########
@@ -652,3 +672,41 @@ test_that("Can use across() within transmute()", {
example_data
)
})
+
+test_that("across() does not select grouping variables within mutate()", {
+ compare_dplyr_binding(
+ .input %>%
+ group_by(chr) %>%
+ mutate(across(everything(), round)) %>%
+ collect(),
+ example_data %>%
+ select(int, dbl, chr)
Review Comment:
nit: it's more skimmable when the `tbl` parameter to
`compare_dplyr_binding()` is just a table with no modification. Please could
you move the `select()` to the `expr` parameter code instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]