baumgold commented on code in PR #436:
URL: https://github.com/apache/arrow-julia/pull/436#discussion_r1192988532
##########
src/table.jl:
##########
@@ -521,6 +521,11 @@ function uncompress(ptr::Ptr{UInt8}, buffer, compression)
len = unsafe_load(convert(Ptr{Int64}, ptr))
ptr += 8 # skip past uncompressed length as Int64
encodedbytes = unsafe_wrap(Array, ptr, buffer.length - 8)
+ if len === -1
Review Comment:
How do we end up in the `uncompress` method for date that is not compressed?
I believe we should be checking for compression earlier than here. Is that a
branch where this check is missing?
##########
src/table.jl:
##########
@@ -521,6 +521,11 @@ function uncompress(ptr::Ptr{UInt8}, buffer, compression)
len = unsafe_load(convert(Ptr{Int64}, ptr))
ptr += 8 # skip past uncompressed length as Int64
encodedbytes = unsafe_wrap(Array, ptr, buffer.length - 8)
+ if len === -1
Review Comment:
How do we end up in the `uncompress` method for data that is not compressed?
I believe we should be checking for compression earlier than here. Is that a
branch where this check is missing?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
