alamb opened a new pull request, #6354: URL: https://github.com/apache/arrow-datafusion/pull/6354
# Which issue does this PR close? Part of https://github.com/apache/arrow-datafusion/issues/6339 # Rationale for this change I want to make it easier to add support for writing to different datasources (I want to implement`COPY ... TO ...` support in https://github.com/apache/arrow-datafusion/issues/5654 and @JanKaul is working to implement a delta.rs target). Initially, I proposed changing the API on `TableProvider` in https://github.com/apache/arrow-datafusion/issues/6339 (see https://github.com/apache/arrow-datafusion/pull/6347) but as the discussion with @ozankabak and @tustvold revealed, keeping the full flexibility if an `ExecutionPlan` if/until we better understand the requirements seems a better course of action. However, I think helping people (like myself) implement `ExecutionPlan`s (and avoid boilerplate) is still be quite helpful. # What changes are included in this PR? 1. Add documentation to `TableProvider::insert_into` 1. Add DataSink API (thanks @tustvold and @JanKaul for this discussion) 2. Refactor the implementation of `MemWriteExec` into `InsertExec` and a `DataSink API` 3. Port explain / insert tests to sqllogictests 4. Add tests for counts # Are these changes tested? Yes # Are there any user-facing changes? There is a new `InsertExec` operator available for users -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
