CurtHagenlocher commented on code in PR #35496:
URL: https://github.com/apache/arrow/pull/35496#discussion_r1194123840
##########
csharp/test/Apache.Arrow.Tests/TestData.cs:
##########
@@ -48,7 +50,7 @@ public static RecordBatch CreateSampleRecordBatch(int length,
int columnSetCount
builder.Field(CreateField(Date32Type.Default, i));
builder.Field(CreateField(Date64Type.Default, i));
builder.Field(CreateField(Time32Type.Default, i));
- builder.Field(CreateField(Time64Type.Default, i));
Review Comment:
Time64 with milliseconds is not explicitly enumerated at
https://arrow.apache.org/docs/format/CDataInterface.html and it would need a
new format specifier to work. This is because "tt" is used for both Time32 and
Time64 and the time unit is used to determine which one it will be. (This is
perhaps an error in the specification, but the spec is what it is.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
