benibus commented on code in PR #35197:
URL: https://github.com/apache/arrow/pull/35197#discussion_r1194131632
##########
cpp/src/arrow/type_test.cc:
##########
@@ -693,25 +851,6 @@ TEST(TestFieldRef, DotPathRoundTrip) {
check_roundtrip(FieldRef("foo", 1, FieldRef("bar", 2, 3), FieldRef()));
}
-TEST(TestFieldPath, Nested) {
- auto f0 = field("alpha", int32());
- auto f1_0 = field("alpha", int32());
- auto f1 = field("beta", struct_({f1_0}));
- auto f2_0 = field("alpha", int32());
- auto f2_1_0 = field("alpha", int32());
- auto f2_1_1 = field("alpha", int32());
- auto f2_1 = field("gamma", struct_({f2_1_0, f2_1_1}));
- auto f2 = field("beta", struct_({f2_0, f2_1}));
- Schema s({f0, f1, f2});
-
- // retrieving fields with nested indices
- EXPECT_EQ(FieldPath({0}).Get(s), f0);
- EXPECT_EQ(FieldPath({1, 0}).Get(s), f1_0);
- EXPECT_EQ(FieldPath({2, 0}).Get(s), f2_0);
- EXPECT_EQ(FieldPath({2, 1, 0}).Get(s), f2_1_0);
- EXPECT_EQ(FieldPath({2, 1, 1}).Get(s), f2_1_1);
-}
-
TEST(TestFieldRef, Nested) {
Review Comment:
Agreed. I wrote the tests before adding the `FieldRef` methods and then
neglected to come back to them... Fortunately, it should be possible to use the
same test case (for the most part).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
