viirya commented on code in PR #6357: URL: https://github.com/apache/arrow-datafusion/pull/6357#discussion_r1194391648
########## docs/source/contributor-guide/index.md: ########## @@ -115,42 +115,41 @@ or run them all at once: - [dev/rust_lint.sh](../../../dev/rust_lint.sh) -### Test Organization +## Testing -Tests are very important to ensure that improvemens or fixes are not accidentally broken during subsequent refactorings. +Tests are critical to ensure that DataFusion is working properly and +is not accidentally broken during refactorings. All new features +should have test coverage. DataFusion has several levels of tests in its [Test Pyramid](https://martinfowler.com/articles/practical-test-pyramid.html) -and tries to follow rust standard [Testing Organization](https://doc.rust-lang.org/book/ch11-03-test-organization.html) in the The Book. +and tries to follow the Rust standard [Testing Organization](https://doc.rust-lang.org/book/ch11-03-test-organization.html) in the The Book. -This section highlights the most important test modules that exist +### Unit tests -#### Unit tests +Tests for code in an individual module are defined in the same source file with a `test` module, following Rust convention. Review Comment: 👍 Looks more clear. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
