kou commented on code in PR #35551:
URL: https://github.com/apache/arrow/pull/35551#discussion_r1194470109
##########
matlab/test/arrow/array/tFloat32Array.m:
##########
@@ -95,5 +95,11 @@ function ErrorIfComplex(testCase, MakeDeepCopy)
fcn = @() arrow.array.Float32Array(single([10 + 1i, 4]),
DeepCopy=MakeDeepCopy);
testCase.verifyError(fcn, "MATLAB:expectedReal");
end
+
+ function ToMATLAB(testCase, MakeDeepCopy)
Review Comment:
```suggestion
function toMATLAB(testCase, MakeDeepCopy)
```
##########
matlab/src/cpp/arrow/matlab/array/proxy/array.cc:
##########
@@ -23,7 +23,7 @@ namespace arrow::matlab::array::proxy {
// Register Proxy methods.
REGISTER_METHOD(Array, ToString);
- REGISTER_METHOD(Array, ToMatlab);
+ REGISTER_METHOD(Array, toMATLAB);
Review Comment:
I'm not familiar with MATLAB API but is it natural that `ToString` uses `T`
and `toMATLAB` uses `t`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
