alamb opened a new issue, #6363:
URL: https://github.com/apache/arrow-datafusion/issues/6363
### Is your feature request related to a problem or challenge?
Sometimes automatic tools create queries like this (where `<VAL>` is a
different value)
```
WHERE ((tenant = '<VAL>') OR (tenant = '<VAL>') OR (tenant = '<VAL>') OR
(tenant = '<VAL>') OR (tenant = '<VAL>') OR (tenant = '<VAL>') OR (tenant =
'<VAL>') OR (tenant = '<VAL>') OR (tenant = '<VAL>') OR (tenant = '<VAL>') OR
(tenant = '<VAL>') OR (tenant = '<VAL>') OR (tenant = '<VAL>') OR (tenant =
'<VAL>') OR (tenant = '<VAL>') OR (tenant = '<VAL>') OR (tenant = '<VAL>') OR
(tenant = '<VAL>') OR (tenant = '<VAL>') OR (tenant = '<VAL>') OR (tenant =
'<VAL>') OR (tenant = '<VAL>') OR (tenant = '<VAL>') OR (tenant = '<VAL>') OR
(tenant = '<VAL>') OR (tenant = '<VAL>') OR (tenant = '<VAL>') OR (tenant =
'<VAL>') OR (tenant = '<VAL>') OR (tenant = '<VAL>') OR (tenant = '<VAL>') OR
(tenant = '<VAL>') OR (tenant = '<VAL>') OR (tenant = '<VAL>') OR (tenant =
'<VAL>') OR (tenant = '<VAL>') OR (tenant = '<VAL>') OR (tenant = '<VAL>') OR
(tenant = '<VAL>') OR (tenant = '<VAL>') OR (tenant = '<VAL>') OR (tenant =
'<VAL>') OR (tenant = '<VAL>') OR (tenant = '<VAL>') OR (tenant = '<VAL>')
OR (tenant = '<VAL>') OR (tenant = '<VAL>') OR (tenant = '<VAL>') OR (tenant =
'<VAL>') OR (tenant = '<VAL>') OR (tenant = '<VAL>') OR (tenant = '<VAL>') OR
(tenant = '<VAL>') OR (tenant = '<VAL>') OR (tenant = '<VAL>') OR (tenant =
'<VAL>') OR (tenant = '<VAL>') OR (tenant = '<VAL>') OR (tenant = '<VAL>') OR
(tenant = '<VAL>') OR (tenant = '<VAL>') OR (tenant = '<VAL>') OR (tenant =
'<VAL>') OR (tenant = '<VAL>') OR (tenant = '<VAL>') OR (tenant = '<VAL>') OR
(tenant = '<VAL>') OR (tenant = '<VAL>') OR (tenant = '<VAL>') OR (tenant =
'<VAL>') OR (tenant = '<VAL>') OR (tenant = '<VAL>') OR (tenant = '<VAL>') OR
(tenant = '<VAL>') OR (tenant = '<VAL>') OR (tenant = '<VAL>') OR (tenant =
'<VAL>') OR (tenant = '<VAL>') OR (tenant = '<VAL>') OR (tenant = '<VAL>') OR
(tenant = '<VAL>') OR (tenant = '<VAL>') OR (tenant = '<VAL>') OR (tenant =
'<VAL>') OR (tenant = '<VAL>') OR (tenant = '<VAL>') OR (tenant = '<VAL>') OR
(tenant = '<VAL>') OR (tenant = '<VAL>') OR (tenant = '<VAL>') OR (ten
ant = '<VAL>') OR (tenant = '<VAL>') OR (tenant = '<VAL>') OR (tenant =
'<VAL>') OR (tenant = '<VAL>') OR (tenant = '<VAL>') OR (tenant = '<VAL>') OR
(tenant = '<VAL>') OR (tenant = '<VAL>') OR (tenant = '<VAL>') OR (tenant =
'<VAL>') OR (tenant = '<VAL>') OR (tenant = '<VAL>') OR (tenant = '<VAL>') OR
(tenant = '<VAL>') OR (tenant = '<VAL>') OR (tenant = '<VAL>') OR (tenant =
'<VAL>') OR (tenant = '<VAL>') OR (tenant = '<VAL>') OR (tenant = '<VAL>') OR
(tenant = '<VAL>') OR (tenant = '<VAL>') OR (tenant = '<VAL>') OR (tenant =
'<VAL>') OR (tenant = '<VAL>') OR (tenant = '<VAL>') OR (tenant = '<VAL>') OR
(tenant = '<VAL>') OR (tenant = '<VAL>') OR (tenant = '<VAL>') OR (tenant =
'<VAL>') OR (tenant = '<VAL>') OR (tenant = '<VAL>') OR (tenant = '<VAL>') OR
(tenant = '<VAL>') OR (tenant = '<VAL>') OR (tenant = '<VAL>') OR (tenant =
'<VAL>') OR (tenant = '<VAL>') OR (tenant = '<VAL>') OR (tenant = '<VAL>') OR
(tenant = '<VAL>') OR (tenant = '<VAL>') OR (tenant = '<VAL>') OR (tenant = '
<VAL>') OR (tenant = '<VAL>') OR (tenant = '<VAL>') OR (tenant = '<VAL>') OR
(tenant = '<VAL>') OR (tenant = '<VAL>') OR (tenant = '<VAL>') OR (tenant =
'<VAL>') OR (tenant = '<VAL>') OR (tenant = '<VAL>') OR (tenant = '<VAL>') OR
(tenant = '<VAL>') OR (tenant = '<VAL>') OR (tenant = '<VAL>') OR (tenant =
'<VAL>') OR (tenant = '<VAL>') OR ...
```
DataFusion's evaluation of an OR chain is fairly slow as it evaluates the
tree recursively
DataFusion's evaluation if IN lists is much faster (builds one hash table
and then checks it). This thus predicate will be much much faster:
```
WHERE tenant IN ('<VAL>', '<VAL>', '<VAL>', '<VAL>', '<VAL>', '<VAL>',
'<VAL>', '<VAL>', .....)
```
There is some heuristic threshold over which it is faster to evaluate using
`OR` rather than `IN`
https://github.com/apache/arrow-datafusion/blob/b578c5819fc05801f2972dd427fbc13cf4773ea8/datafusion/optimizer/src/simplify_expressions/expr_simplifier.rs#L45
Which rewrites queries from `IN` to `OR` when the number of constants is too
low
https://github.com/apache/arrow-datafusion/blob/b578c5819fc05801f2972dd427fbc13cf4773ea8/datafusion/optimizer/src/simplify_expressions/expr_simplifier.rs#L414-L445
### Describe the solution you'd like
I would like to add a rewrite rule that rewrites queries like
```sql
WHERE ((tenant = '<VAL>') OR (tenant = '<VAL>')....
```
```sql
WHERE tenant = ('<VAL>', '<VAL>', ...)
```
When:
1. There are more than the[ InList
threshold](https://github.com/apache/arrow-datafusion/blob/b578c5819fc05801f2972dd427fbc13cf4773ea8/datafusion/optimizer/src/simplify_expressions/expr_simplifier.rs#L45)
### Describe alternatives you've considered
_No response_
### Additional context
_No response_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
