tustvold commented on code in PR #6364:
URL: https://github.com/apache/arrow-datafusion/pull/6364#discussion_r1195249166
##########
datafusion/core/src/physical_plan/metrics/baseline.rs:
##########
@@ -43,25 +43,16 @@ use crate::error::Result;
/// // when operator is finished:
/// baseline_metrics.done();
/// ```
-#[derive(Debug)]
+#[derive(Debug, Clone)]
pub struct BaselineMetrics {
/// end_time is set when `ExecutionMetrics::done()` is called
- end_time: Timestamp,
+ pub end_time: Timestamp,
/// amount of time the operator was actively trying to use the CPU
- elapsed_compute: Time,
-
- /// count of spills during the execution of the operator
- spill_count: Count,
-
- /// total spilled bytes during the execution of the operator
- spilled_bytes: Count,
-
- /// current memory usage for the operator
- mem_used: Gauge,
Review Comment:
These were only used by ExternalSorter and so I figure aren't really Baseline
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
