rtpsw commented on code in PR #35608:
URL: https://github.com/apache/arrow/pull/35608#discussion_r1195396061
##########
cpp/src/arrow/engine/substrait/ext_test.cc:
##########
@@ -285,5 +340,55 @@ TEST(ExtensionIdRegistryTest, RegisterNestedFunctions) {
}
}
+TEST(ExtensionIdRegistryTest, RegisterNestedAggregates) {
Review Comment:
All but the last test I added (this one included) are for aggregate
registration that were just missing. They are not specifically related to the
main-code change here, but IMHO they are needed for basic coverage. They follow
the existing tests for function registration.
The last test I added is the one that specifically covers the main-code
change here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
