icexelloss commented on code in PR #35514: URL: https://github.com/apache/arrow/pull/35514#discussion_r1195547024
########## cpp/src/arrow/engine/substrait/extension_set.cc: ########## @@ -355,6 +355,68 @@ ExtensionIdRegistry::SubstraitCallToArrow kSimpleSubstraitToArrow = return ::arrow::compute::call(std::string(call.id().name), std::move(args)); }; +ExtensionIdRegistry::SubstraitAggregateToArrow DecodeBasicAggregate( Review Comment: TODO: Revert this change after https://github.com/apache/arrow/pull/35608 is merged ########## cpp/src/arrow/engine/substrait/extension_set.cc: ########## @@ -592,6 +654,10 @@ struct ExtensionIdRegistryImpl : ExtensionIdRegistry { Result<SubstraitAggregateToArrow> GetSubstraitAggregateToArrow( Id substrait_function_id) const override { + + if (substrait_function_id.uri == kArrowSimpleExtensionFunctionsUri) { Review Comment: TODO: Revert this change after https://github.com/apache/arrow/pull/35608 is merged -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
