pitrou commented on PR #34392: URL: https://github.com/apache/arrow/pull/34392#issuecomment-1551281586
> Removing `options_internal.h` led to [a different CI job failure](https://github.com/apache/arrow/actions/runs/4995566499/jobs/8947588727?pr=34392) where `#include <mutex>` is forbidden in a public header. I now recall this is why I created `options_internal.h` in the first place. I'm attempting a fix. There's `arrow/util/mutex.h` specifically for this. However, we should generally strive to keep the amount of implementation code in public headers under control. The heavier public headers are, the longer the compile times. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
