kszucs commented on a change in pull request #8886:
URL: https://github.com/apache/arrow/pull/8886#discussion_r540105542
##########
File path: cpp/src/arrow/util/converter.h
##########
@@ -294,6 +302,34 @@ class Chunker {
return status;
}
+ // we could get bit smarter here since the whole batch of appendable values
+ // will be rejected if a capacity error is raised
+ Status Extend(InputType values, int64_t size) {
Review comment:
The chunker's extend wrapper is untested since we use `Append` from the
python code. Theoretically we can wrap the converter's `Extend` method just
like in the case of `Append` though we reject the whole batch rather than a
single item.
We could improve this logic but would require details about the iteration.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
