pitrou commented on code in PR #35605:
URL: https://github.com/apache/arrow/pull/35605#discussion_r1196430612
##########
cpp/src/parquet/encryption/test_encryption_util.cc:
##########
@@ -322,9 +322,20 @@ void ReadAndVerifyColumn(RowGroupReader* rg_reader,
RowGroupMetadata* rg_md,
}
ASSERT_EQ(rows_read, rows_should_read);
ASSERT_EQ(values_read, rows_should_read);
- ASSERT_EQ(read_col_data.values, expected_column_data.values);
// make sure we got the same number of values the metadata says
ASSERT_EQ(col_md->num_values(), rows_read);
+ if constexpr (std::is_floating_point_v<typename DType::c_type>) {
Review Comment:
```suggestion
// GH-35571: need to use approximate floating-point comparison because of
// precision issues on MinGW32 (the values generated in the C++ test code
// may not exactly match those from the parquet-testing data files).
if constexpr (std::is_floating_point_v<typename DType::c_type>) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
