felipecrv commented on code in PR #35036:
URL: https://github.com/apache/arrow/pull/35036#discussion_r1196445238
##########
cpp/src/arrow/array/data.cc:
##########
@@ -236,6 +236,19 @@ void SetOffsetsForScalar(ArraySpan* span, offset_type*
buffer, int64_t value_siz
span->buffers[buffer_index].size = 2 * sizeof(offset_type);
}
+template <typename ArrowType>
+void SetRunForScalar(ArraySpan* span, std::shared_ptr<DataType> type,
+ uint64_t* scratch_space) {
+ // Create a lenght-1 array with the value 1 for a REE scalar
Review Comment:
I think the comment can be removed after the other changes that clarify the
code are made.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
