pitrou commented on code in PR #35197:
URL: https://github.com/apache/arrow/pull/35197#discussion_r1196531763
##########
cpp/src/arrow/type_test.cc:
##########
@@ -364,152 +365,341 @@ TEST(TestField, TestMerge) {
}
}
-TEST(TestFieldPath, Basics) {
- auto f0 = field("alpha", int32());
- auto f1 = field("beta", int32());
- auto f2 = field("alpha", int32());
- auto f3 = field("beta", int32());
- Schema s({f0, f1, f2, f3});
+struct FieldPathTestCase {
Review Comment:
Given that this is adding quite a lot of test code, and this file is already
long, I think it may be time to move the `Field{Ref,Path}` tests to a separate
test module.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
