icexelloss commented on code in PR #35514:
URL: https://github.com/apache/arrow/pull/35514#discussion_r1196688039
##########
python/pyarrow/tests/test_substrait.py:
##########
@@ -605,3 +605,151 @@ def table_provider(names, schema):
expected = pa.Table.from_pydict({"out": [1, 2, 3]})
assert res_tb == expected
+
+
+def test_aggregate_udf_basic(varargs_agg_func_fixture):
+
+ test_table = pa.Table.from_pydict(
+ {"k": [1, 1, 2, 2], "v1": [1.0, 2.0, 3.0, 4.0],
+ "v2": [1.0, 1.0, 1.0, 1.0]}
+ )
+
+ def table_provider(names, _):
+ return test_table
+
+ substrait_query = b"""
+{
+ "extensionUris": [
+ {
+ "extensionUriAnchor": 1,
+ "uri": "urn:arrow:substrait_simple_extension_function"
+ },
+ ],
+ "extensions": [
+ {
+ "extensionFunction": {
+ "extensionUriReference": 1,
+ "functionAnchor": 1,
+ "name": "y=sum_mean(x...)"
+ }
+ }
+ ],
+ "relations": [
+ {
+ "root": {
+ "input": {
+ "extensionSingle": {
+ "common": {
+ "emit": {
+ "outputMapping": [
+ 0,
+ 1
+ ]
+ }
+ },
+ "input": {
+ "read": {
+ "baseSchema": {
+ "names": [
+ "k",
+ "v1",
+ "v2",
+ ],
+ "struct": {
+ "types": [
+ {
+ "i64": {
+ "nullability": "NULLABILITY_REQUIRED"
+ }
+ },
+ {
+ "fp64": {
Review Comment:
TODO: Change so that v1 and v2 have different types
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
