zeroshade commented on code in PR #681:
URL: https://github.com/apache/arrow-adbc/pull/681#discussion_r1196691729
##########
adbc.h:
##########
@@ -669,6 +675,16 @@ struct ADBC_EXPORT AdbcDriver {
size_t, struct AdbcError*);
};
+/// \brief An instance of an initialized database driver (API 1.1.0).
+///
+/// This provides a common interface for vendor-specific driver
+/// initialization routines. Drivers should populate this struct, and
+/// applications can call ADBC functions through this struct, without
+/// worrying about multiple definitions of the same symbol.
+struct ADBC_EXPORT AdbcDriver110 {
+ struct AdbcDriver base;
+};
Review Comment:
Why do we need a new struct? Isn't the purpose of the version to be so that
we don't need a new struct?
This feels like it's going to be a never-ending escalator if we have to
always keep embedding the previous one
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
