jorisvandenbossche commented on code in PR #35634:
URL: https://github.com/apache/arrow/pull/35634#discussion_r1196702982
##########
cpp/src/arrow/compute/kernels/scalar_temporal_unary.cc:
##########
@@ -120,7 +120,7 @@ struct AssumeTimezoneExtractor
static Status Exec(KernelContext* ctx, const ExecSpan& batch, ExecResult*
out) {
const AssumeTimezoneOptions& options = AssumeTimezoneState::Get(ctx);
const auto& timezone = GetInputTimezone(*batch[0].type());
- if (!timezone.empty()) {
+ if (!timezone.empty() && timezone != options.timezone) {
Review Comment:
This should be reverted back I think (it shouldn't be needed to fix the
failures, and I _think_ it's better to keep the "assume_timezone" kernel strict
about input being tz-naive)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
