alamb commented on code in PR #4237:
URL: https://github.com/apache/arrow-rs/pull/4237#discussion_r1197008114
##########
object_store/src/aws/credential.rs:
##########
@@ -72,8 +73,12 @@ impl AwsCredential {
}
}
-struct RequestSigner<'a> {
- date: DateTime<Utc>,
+/// Authorize a [`Request`] with an [`AwsCredential`] using [AWS SigV4]
Review Comment:
It might help to say that the way a request is authorized is that the
appropriate headers are added
Maybe
```
/// Add Authorization headers to `request` with an optional
pre-calculated SHA256 digest
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
