roeap commented on issue #4240: URL: https://github.com/apache/arrow-rs/issues/4240#issuecomment-1552913838
The way to go is maybe to keep the augmentation logic as a separate step, and not make it part of the builders itself. In test scenarios One would create a specific store instance via the builder, and may choose the have a config helper that augments from the env as a pre-processing step for the config before it gets passed into the builder. Obviously that only works for the config API. Erroring in an ambiguous case - especially in the builder - seems very reasonable to me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
