tustvold commented on code in PR #6382:
URL: https://github.com/apache/arrow-datafusion/pull/6382#discussion_r1198003398
##########
datafusion/execution/src/memory_pool/pool.rs:
##########
@@ -145,21 +145,21 @@ impl MemoryPool for FairSpillPool {
fn unregister(&self, consumer: &MemoryConsumer) {
if consumer.can_spill {
- self.state.lock().num_spill -= 1;
+ self.state.lock().num_spill.checked_sub(1).unwrap();
Review Comment:
Drive by sanity check (as first version of `MemoryReservation::split` would
unregister the same consumer multiple times :sweat_smile:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
