alamb commented on code in PR #6362:
URL: https://github.com/apache/arrow-datafusion/pull/6362#discussion_r1198180698
##########
datafusion/core/tests/sqllogictests/src/setup.rs:
##########
@@ -29,8 +29,41 @@ use datafusion::{
test_util,
};
use std::sync::Arc;
+use datafusion::prelude::AvroReadOptions;
-use crate::utils;
+use crate::{TestContext, utils};
+
+pub async fn register_avro_tables(ctx: &mut TestContext) {
+ register_avro_test_data(ctx).await;
+}
+
+async fn register_avro_test_data(ctx: &mut TestContext) {
+ ctx.enable_testdir();
Review Comment:
👍 looks good to me -- I think it may even make sense to always create the
temp directory but for now making it just for avro looks great.
##########
datafusion/core/tests/sqllogictests/test_files/avro.slt:
##########
@@ -0,0 +1,97 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+
+# http://www.apache.org/licenses/LICENSE-2.0
+
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+
+statement ok
+CREATE EXTERNAL TABLE alltypes_plain (
+ id INT NOT NULL,
+ bool_col BOOLEAN NOT NULL,
+ tinyint_col TINYINT NOT NULL,
+ smallint_col SMALLINT NOT NULL,
+ int_col INT NOT NULL,
+ bigint_col BIGINT NOT NULL,
+ float_col FLOAT NOT NULL,
+ double_col DOUBLE NOT NULL,
+ date_string_col BYTEA NOT NULL,
+ string_col VARCHAR NOT NULL,
+ timestamp_col TIMESTAMP NOT NULL,
+)
+STORED AS AVRO
+WITH HEADER ROW
+LOCATION '../../testing/data/avro/alltypes_plain.avro'
+
+statement ok
+CREATE EXTERNAL TABLE single_nan (
+ mycol FLOAT
+)
+STORED AS AVRO
+WITH HEADER ROW
+LOCATION '../../testing/data/avro/single_nan.avro'
+
+# test avro query
+query IT
+SELECT id, CAST(string_col AS varchar) FROM alltypes_plain
+----
+4 0
+5 1
+6 0
+7 1
+2 0
+3 1
+0 0
+1 1
+
+# test avro single nan schema
+query R
+SELECT mycol FROM single_nan
+----
+NULL
+
+# test avro query multi files
Review Comment:
👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
