benibus commented on PR #35280: URL: https://github.com/apache/arrow/pull/35280#issuecomment-1553757556
After some ad-hoc testing, the benchmark' array lengths/sizes should be essentially the same now between the dict and non-dict versions. For strings, the dict versions _slightly_ overshoot the others (in terms of bytes) due to some null overlap between the index/value arrays. I also added some special-casing for the 100% null benchmarks - primarily to ensure that the input `DictionaryArray` was actually 0 bytes (like the `StringArray` equivalents). Caveat: it only tests the best-case scenario - i.e. where the index and/or value array is entirely null. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
