quinnj commented on PR #419: URL: https://github.com/apache/arrow-julia/pull/419#issuecomment-1553761868
Ok, PR up: https://github.com/apache/arrow-julia/pull/439. Sorry to be so MIA lately; I've been tied up in some heavy other projects and it's been too hard to context-switch back here. A lot of that work (webstack-related) has wrapped up (mostly), I'm hoping to have more time to help review/fix stuff here. This PR was definitely in the right direction @Moelf; thanks for the contribution. It was a great starting point. Couple of specific points: * I'd rather not pun the `ArrowTypes.isstringtype` function for non-ListKind types; it keeps that a little cleaner IMO * We can make Base.CodeUnits the main translation between the Arrow Binary type * We can add some compat shims in Arrow to avoid the awkward ArrowTypes/Arrow mis-compat -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
