kou opened a new pull request, #35680:
URL: https://github.com/apache/arrow/pull/35680
### Rationale for this change
Large/small double values are truncated with MinGW 32bit. We can skip tests
that depend on large/small double values with MinGW 32bit or change expected
values for these cases.
```text
[----------] 2 tests from TestDecimalFromReal/1, where TypeParam =
std::pair<arrow::Decimal128, double>
[ RUN ] TestDecimalFromReal/1.TestSuccess
D:/a/arrow/arrow/cpp/src/arrow/util/decimal_test.cc:766: Failure
Expected equality of these values:
dec.ToString(scale)
Which is: "4611686000000000000"
expected
Which is: "4611686018427387904"
D:/a/arrow/arrow/cpp/src/arrow/util/decimal_test.cc:766: Failure
Expected equality of these values:
dec.ToString(scale)
Which is: "-4611686000000000000"
expected
Which is: "-4611686018427387904"
D:/a/arrow/arrow/cpp/src/arrow/util/decimal_test.cc:766: Failure
Expected equality of these values:
dec.ToString(scale)
Which is: "9223372000000000000"
expected
Which is: "9223372036854775808"
D:/a/arrow/arrow/cpp/src/arrow/util/decimal_test.cc:766: Failure
Expected equality of these values:
dec.ToString(scale)
Which is: "-9223372000000000000"
expected
Which is: "-9223372036854775808"
D:/a/arrow/arrow/cpp/src/arrow/util/decimal_test.cc:766: Failure
Expected equality of these values:
dec.ToString(scale)
Which is: "18446744000000000000"
expected
Which is: "18446744073709551616"
D:/a/arrow/arrow/cpp/src/arrow/util/decimal_test.cc:766: Failure
Expected equality of these values:
dec.ToString(scale)
Which is: "-18446744000000000000"
expected
Which is: "-18446744073709551616"
[ FAILED ] TestDecimalFromReal/1.TestSuccess, where TypeParam =
std::pair<arrow::Decimal128, double> (0 ms)
[ RUN ] TestDecimalFromReal/1.TestErrors
[ OK ] TestDecimalFromReal/1.TestErrors (0 ms)
[----------] 2 tests from TestDecimalFromReal/1 (0 ms total)
[----------] 2 tests from TestDecimalFromReal/2, where TypeParam =
std::pair<arrow::Decimal256, float>
[ RUN ] TestDecimalFromReal/2.TestSuccess
[ OK ] TestDecimalFromReal/2.TestSuccess (0 ms)
[ RUN ] TestDecimalFromReal/2.TestErrors
[ OK ] TestDecimalFromReal/2.TestErrors (0 ms)
[----------] 2 tests from TestDecimalFromReal/2 (0 ms total)
[----------] 2 tests from TestDecimalFromReal/3, where TypeParam =
std::pair<arrow::Decimal256, double>
[ RUN ] TestDecimalFromReal/3.TestSuccess
D:/a/arrow/arrow/cpp/src/arrow/util/decimal_test.cc:766: Failure
Expected equality of these values:
dec.ToString(scale)
Which is: "4611686000000000000"
expected
Which is: "4611686018427387904"
D:/a/arrow/arrow/cpp/src/arrow/util/decimal_test.cc:766: Failure
Expected equality of these values:
dec.ToString(scale)
Which is: "-4611686000000000000"
expected
Which is: "-4611686018427387904"
D:/a/arrow/arrow/cpp/src/arrow/util/decimal_test.cc:766: Failure
Expected equality of these values:
dec.ToString(scale)
Which is: "9223372000000000000"
expected
Which is: "9223372036854775808"
D:/a/arrow/arrow/cpp/src/arrow/util/decimal_test.cc:766: Failure
Expected equality of these values:
dec.ToString(scale)
Which is: "-9223372000000000000"
expected
Which is: "-9223372036854775808"
D:/a/arrow/arrow/cpp/src/arrow/util/decimal_test.cc:766: Failure
Expected equality of these values:
dec.ToString(scale)
Which is: "18446744000000000000"
expected
Which is: "18446744073709551616"
D:/a/arrow/arrow/cpp/src/arrow/util/decimal_test.cc:766: Failure
Expected equality of these values:
dec.ToString(scale)
Which is: "-18446744000000000000"
expected
Which is: "-18446744073709551616"
[ FAILED ] TestDecimalFromReal/3.TestSuccess, where TypeParam =
std::pair<arrow::Decimal256, double> (0 ms)
[ RUN ] TestDecimalFromReal/3.TestErrors
```
### What changes are included in this PR?
This changes expected values only for MinGW 32bit.
### Are these changes tested?
Yes.
### Are there any user-facing changes?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
