westonpace commented on code in PR #34651:
URL: https://github.com/apache/arrow/pull/34651#discussion_r1198950813
##########
cpp/src/arrow/engine/substrait/relation_internal.cc:
##########
@@ -329,6 +329,23 @@ ARROW_ENGINE_EXPORT Result<DeclarationInfo>
MakeAggregateDeclaration(
} // namespace internal
+namespace {
+
+bool IsSortNullsFirst(const substrait::SortField::SortDirection& direction) {
+ return direction % 2 == 1;
Review Comment:
I've switched to proper handling of these cases and I return NullPlacement
and SortOrder. I agree the code is more readable now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
