mapleFU commented on code in PR #35613:
URL: https://github.com/apache/arrow/pull/35613#discussion_r1199077497
##########
cpp/src/arrow/array/builder_binary.h:
##########
@@ -67,7 +67,7 @@ class BaseBinaryBuilder
Status Append(const uint8_t* value, offset_type length) {
ARROW_RETURN_NOT_OK(Reserve(1));
- ARROW_RETURN_NOT_OK(AppendNextOffset());
+ UnsafeAppendNextOffset();
Review Comment:
Hi, since `Append` is a public interface, how can user make sure that the
offset is reserved before?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]