alamb commented on a change in pull request #8888:
URL: https://github.com/apache/arrow/pull/8888#discussion_r540527213
##########
File path: rust/datafusion/src/logical_plan/dfschema.rs
##########
@@ -89,11 +89,11 @@ impl DFSchema {
}
/// Create a `DFSchema` from an Arrow schema
- pub fn from(schema: &Schema) -> Result<Self> {
+ pub fn try_from(schema: Schema) -> Result<Self> {
Review comment:
That is an excellent point -- I will update the code to use that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
