zeroshade commented on code in PR #35654:
URL: https://github.com/apache/arrow/pull/35654#discussion_r1200758149
##########
go/arrow/compute/arithmetic.go:
##########
@@ -627,6 +627,8 @@ func RegisterScalarArithmetic(reg FunctionRegistry) {
}{
{"sub_unchecked", kernels.OpSub, decPromoteAdd,
subUncheckedDoc},
{"sub", kernels.OpSubChecked, decPromoteAdd, subDoc},
+ {"subtract_unchecked", kernels.OpSub, decPromoteAdd,
subUncheckedDoc},
+ {"subtract", kernels.OpSubChecked, decPromoteAdd, subDoc},
Review Comment:
just made things easier since for all of the *other* functions I was able to
have a simple loop since the names matched and I didn't want to have a separate
case for only subtract. It's not strictly needed, it just made some code
cleaner.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
