CurtHagenlocher commented on code in PR #35716:
URL: https://github.com/apache/arrow/pull/35716#discussion_r1201005376
##########
csharp/src/Apache.Arrow/Field.cs:
##########
@@ -35,24 +35,24 @@ public partial class Field
public Field(string name, IArrowType dataType, bool nullable,
IEnumerable<KeyValuePair<string, string>> metadata = default)
- : this(name, dataType, nullable)
+ : this(name, dataType, nullable, false)
{
Metadata = metadata?.ToDictionary(kv => kv.Key, kv => kv.Value);
}
internal Field(string name, IArrowType dataType, bool nullable,
- IReadOnlyDictionary<string, string> metadata, bool copyCollections)
- : this(name, dataType, nullable)
+ IReadOnlyDictionary<string, string> metadata, bool
copyCollections, bool allowBlankName)
+ : this(name, dataType, nullable, allowBlankName)
{
Debug.Assert(copyCollections == false, "This internal constructor
is to not copy the collections.");
Metadata = metadata;
}
- private Field(string name, IArrowType dataType, bool nullable)
+ private Field(string name, IArrowType dataType, bool nullable, bool
allowBlankName)
Review Comment:
I concede that this change is a bit odd; the intent was to address #32886.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
